Repository navigation
Conversation
An empty serial version 3 CompactTupleSketch image must now have PreLongs=1, SerVer=3, Family=TUPLE, SketchType=CompactTupleSketch, a zero unused byte, and the read-only, empty and compact flags set with the reserved bits clear. The ordered flag and the seed hash are ignored, as in theta (#776), so every image written by Java since 3.1.0, C++ and Go still reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CompactTupleSketchreader now checks the first 8 bytes of an empty serial version 3 image, as the theta reader does since #776. Before this change, any image with the empty flag set was accepted, whatever its other preamble bytes held.An empty image must have:
Ignored, as in theta:
tuple_int_n0_go.skcarries the default seed hash.Every empty-image writer checked writes this form: Java from 3.1.0 on (when serial version 3 began), C++ from 3.0.0 on, and Go. Legacy images (serial versions 1 and 2) are not changed.
Tests: the new
TupleEmptyImageTestaccepts the Java, older Java, C++ and Go empty forms, ignores the seed hash under a custom seed, and accepts trailing bytes. It rejects PreLongs 2 or 3, a nonzero unused byte, a missing read-only or compact flag, and each reserved flag bit. The four rejection tests fail on main.check_cpp_files,check_go_files,check_rust_filesandcheck_cpp_historical_filespass.The array-of-doubles compact reader is not changed here.
🤖 Generated with Claude Code